From: hno <>
Date: Sun, 7 Nov 2004 04:37:59 +0000 (+0000)
Subject: Bug #1102: O_NONBLOCK on disk files is not a wise idea as this
X-Git-Tag: SQUID_3_0_PRE4~1006
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=92f3ddfbb4b10a9f6a411c8ff4aef7fc3bb050f0;p=thirdparty%2Fsquid.git

Bug #1102: O_NONBLOCK on disk files is not a wise idea as this
is not standardized, and results may be unexpected.

Especially considering Linux now starts to add O_NONBLOCK support
on disk files but the implementation is far from complete yet.
---

diff --git a/src/disk.cc b/src/disk.cc
index 80572a5338..20a4ca5e50 100644
--- a/src/disk.cc
+++ b/src/disk.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: disk.cc,v 1.165 2003/04/24 06:35:08 hno Exp $
+ * $Id: disk.cc,v 1.166 2004/11/06 21:37:59 hno Exp $
  *
  * DEBUG: section 6     Disk I/O Routines
  * AUTHOR: Harvest Derived
@@ -67,8 +67,6 @@ file_open(const char *path, int mode)
     if (FILE_MODE(mode) == O_WRONLY)
         mode |= O_APPEND;
 
-    mode |= SQUID_NONBLOCK;
-
     errno = 0;
 
     fd = open(path, mode, 0644);