From: Ethan Carter Edwards Date: Thu, 27 Feb 2025 23:16:22 +0000 (-0500) Subject: drm/amd/display: change kzalloc to kcalloc in dcn31_validate_bandwidth() X-Git-Tag: v6.15-rc1~120^2~2^2~42 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=934cb529e90c57f5766668fe13624624dae1d790;p=thirdparty%2Flinux.git drm/amd/display: change kzalloc to kcalloc in dcn31_validate_bandwidth() We are trying to get rid of all multiplications from allocation functions to prevent integer overflows. Here the multiplication is probably safe, but using kcalloc() is more appropriate and improves readability. This patch has no effect on runtime behavior. Reviewed-by: Rodrigo Siqueira Reviewed-by: Alex Hung Signed-off-by: Ethan Carter Edwards Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c index 3c42ba8566cf8..dddddbfef85f8 100644 --- a/drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c @@ -1768,7 +1768,8 @@ bool dcn31_validate_bandwidth(struct dc *dc, int vlevel = 0; int pipe_cnt = 0; - display_e2e_pipe_params_st *pipes = kzalloc(dc->res_pool->pipe_count * sizeof(display_e2e_pipe_params_st), GFP_KERNEL); + display_e2e_pipe_params_st *pipes = kcalloc(dc->res_pool->pipe_count, + sizeof(display_e2e_pipe_params_st), GFP_KERNEL); DC_LOGGER_INIT(dc->ctx->logger); BW_VAL_TRACE_COUNT();