From: Jim Meyering Date: Sun, 8 Mar 2009 17:37:08 +0000 (+0100) Subject: tests: add a test for newly-fixed bug in comm --check-order X-Git-Tag: v7.2~47 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=93f6771e82401f4c88219938602d4f09628301f4;p=thirdparty%2Fcoreutils.git tests: add a test for newly-fixed bug in comm --check-order * tests/misc/comm (ooo-prefix): Add a test for today's fix. * NEWS (Bug fixes): Mention it. --- diff --git a/NEWS b/NEWS index 63c7e19dd7..fd101a4006 100644 --- a/NEWS +++ b/NEWS @@ -4,6 +4,11 @@ GNU coreutils NEWS -*- outline -*- ** Bug fixes + comm's new --check-order option would fail to detect disorder on any pair + of lines where one was a prefix of the other. For example, this would + fail to report the disorder: printf 'Xb\nX\n'>k; comm --check-order k k + [bug introduced in coreutils-7.0] + cp once again diagnoses the invalid "cp -rl dir dir" right away, rather than after creating a very deep dir/dir/dir/... hierarchy. The bug strikes only with both --recursive (-r, -R) and --link (-l). diff --git a/tests/misc/comm b/tests/misc/comm index 81a8529449..80a0c2dd39 100755 --- a/tests/misc/comm +++ b/tests/misc/comm @@ -2,7 +2,7 @@ # -*- perl -*- # Test comm -# Copyright (C) 2008 Free Software Foundation, Inc. +# Copyright (C) 2008-2009 Free Software Foundation, Inc. # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -116,6 +116,13 @@ my @Tests = {OUT => "\t\t2\n"}, {ERR => "$prog: file 1 is not in sorted order\n"}], + # out-of-order, line 2 is a prefix of line 1 + # until coreutils-7.2, this test would fail -- no disorder detected + ['ooo-prefix', '--check-order', {IN=>{a=>"Xa\nX\n"}}, {IN=>{b=>""}}, + {EXIT=>1}, + {OUT => "Xa\n"}, + {ERR => "$prog: file 1 is not in sorted order\n"}], + # alternate delimiter: ',' ['delim-comma', '--output-delimiter=,', @inputs, {OUT=>"1\n,2\n,,3\n"} ],