From: Colin Ian King Date: Tue, 5 Sep 2017 15:03:48 +0000 (+0100) Subject: clk: cdce925: remove redundant check for non-null parent_name X-Git-Tag: v4.15-rc1~48^2^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9416a5f8842a37dc356b7855867d20db6dfa9e3a;p=thirdparty%2Fkernel%2Flinux.git clk: cdce925: remove redundant check for non-null parent_name The check for a non-null parent_name is always true as there is an earlier check for a null parent_name that returns -ENODEV. Remove this redundant check and always set init.num_parents to 1. Detected by CoverityScan CID#1309477 ("Logically dead code") Signed-off-by: Colin Ian King Signed-off-by: Stephen Boyd --- diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c index c933be01c7db6..0a7e7d5a75060 100644 --- a/drivers/clk/clk-cdce925.c +++ b/drivers/clk/clk-cdce925.c @@ -665,7 +665,7 @@ static int cdce925_probe(struct i2c_client *client, init.ops = &cdce925_pll_ops; init.flags = 0; init.parent_names = &parent_name; - init.num_parents = parent_name ? 1 : 0; + init.num_parents = 1; /* Register PLL clocks */ for (i = 0; i < data->chip_info->num_plls; ++i) {