From: Johannes Berg Date: Fri, 5 Jul 2024 11:42:06 +0000 (+0200) Subject: net: page_pool: fix warning code X-Git-Tag: v6.11-rc1~163^2~75 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=946b6c48cca48591fb495508c5dbfade767173d0;p=thirdparty%2Flinux.git net: page_pool: fix warning code WARN_ON_ONCE("string") doesn't really do what appears to be intended, so fix that. Signed-off-by: Johannes Berg Fixes: 90de47f020db ("page_pool: fragment API support for 32-bit arch with 64-bit DMA") Link: https://patch.msgid.link/20240705134221.2f4de205caa1.I28496dc0f2ced580282d1fb892048017c4491e21@changeid Signed-off-by: Jakub Kicinski --- diff --git a/net/core/page_pool.c b/net/core/page_pool.c index dc52f078addeb..855271a6cad24 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -444,7 +444,7 @@ static bool page_pool_dma_map(struct page_pool *pool, netmem_ref netmem) return true; unmap_failed: - WARN_ON_ONCE("unexpected DMA address, please report to netdev@"); + WARN_ONCE(1, "unexpected DMA address, please report to netdev@"); dma_unmap_page_attrs(pool->p.dev, dma, PAGE_SIZE << pool->p.order, pool->p.dma_dir, DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_WEAK_ORDERING);