From: Nguyễn Thái Ngọc Duy Date: Sun, 26 Mar 2017 02:42:26 +0000 (+0700) Subject: refs: rename lookup_ref_store() to lookup_submodule_ref_store() X-Git-Tag: v2.13.0-rc0~9^2~15 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9476c6ed3dcf89b045d567c153f50de9528dd0ba;p=thirdparty%2Fgit.git refs: rename lookup_ref_store() to lookup_submodule_ref_store() With get_main_ref_store() being used inside get_ref_store(), lookup_ref_store() is only used for submodule code path. Rename to reflect that and delete dead code. Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano --- diff --git a/refs.c b/refs.c index 8aa33af4e8..a4a1a4ccfd 100644 --- a/refs.c +++ b/refs.c @@ -1395,17 +1395,13 @@ static struct ref_store *main_ref_store; static struct hashmap submodule_ref_stores; /* - * Return the ref_store instance for the specified submodule (or the - * main repository if submodule is NULL). If that ref_store hasn't - * been initialized yet, return NULL. + * Return the ref_store instance for the specified submodule. If that + * ref_store hasn't been initialized yet, return NULL. */ -static struct ref_store *lookup_ref_store(const char *submodule) +static struct ref_store *lookup_submodule_ref_store(const char *submodule) { struct submodule_hash_entry *entry; - if (!submodule) - return main_ref_store; - if (!submodule_ref_stores.tablesize) /* It's initialized on demand in register_ref_store(). */ return NULL; @@ -1471,7 +1467,7 @@ struct ref_store *get_ref_store(const char *submodule) if (!submodule || !*submodule) { return get_main_ref_store(); } else { - refs = lookup_ref_store(submodule); + refs = lookup_submodule_ref_store(submodule); if (!refs) { struct strbuf submodule_sb = STRBUF_INIT; @@ -1482,7 +1478,6 @@ struct ref_store *get_ref_store(const char *submodule) strbuf_release(&submodule_sb); } } - return refs; }