From: Felix Fietkau <nbd@nbd.name>
Date: Tue, 19 Jan 2021 12:19:53 +0000 (+0100)
Subject: mt76: fix crash on tearing down ext phy
X-Git-Tag: v5.12-rc1~200^2~62^2~16^2~32
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=94b6df08da9c4e0f96d3fbd2ec79c40d8cdac4ae;p=thirdparty%2Fkernel%2Flinux.git

mt76: fix crash on tearing down ext phy

Only clear dev->phy2 after the phy is gone, the driver may still need to access
it until shutdown is complete

Signed-off-by: Felix Fietkau <nbd@nbd.name>
---

diff --git a/drivers/net/wireless/mediatek/mt76/mac80211.c b/drivers/net/wireless/mediatek/mt76/mac80211.c
index f2714436883b7..696d00d1976ca 100644
--- a/drivers/net/wireless/mediatek/mt76/mac80211.c
+++ b/drivers/net/wireless/mediatek/mt76/mac80211.c
@@ -387,9 +387,9 @@ void mt76_unregister_phy(struct mt76_phy *phy)
 {
 	struct mt76_dev *dev = phy->dev;
 
-	dev->phy2 = NULL;
 	mt76_tx_status_check(dev, NULL, true);
 	ieee80211_unregister_hw(phy->hw);
+	dev->phy2 = NULL;
 }
 EXPORT_SYMBOL_GPL(mt76_unregister_phy);