From: Ilya Dryomov <idryomov@gmail.com>
Date: Thu, 30 Jan 2020 12:54:59 +0000 (+0100)
Subject: rbd: remove barriers from img_request_layered_{set,clear,test}()
X-Git-Tag: v5.7-rc1~39^2~44
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=94f4857f4ba21aad4cf11dde961ea23a07b5161c;p=thirdparty%2Fkernel%2Flinux.git

rbd: remove barriers from img_request_layered_{set,clear,test}()

IMG_REQ_LAYERED is set in rbd_img_request_create(), and tested and
cleared in rbd_img_request_destroy() when the image request is about to
be destroyed.  The barriers are unnecessary.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
---

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 6343402c09e61..162fd1df06dd8 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -1366,18 +1366,15 @@ static void rbd_osd_submit(struct ceph_osd_request *osd_req)
 static void img_request_layered_set(struct rbd_img_request *img_request)
 {
 	set_bit(IMG_REQ_LAYERED, &img_request->flags);
-	smp_mb();
 }
 
 static void img_request_layered_clear(struct rbd_img_request *img_request)
 {
 	clear_bit(IMG_REQ_LAYERED, &img_request->flags);
-	smp_mb();
 }
 
 static bool img_request_layered_test(struct rbd_img_request *img_request)
 {
-	smp_mb();
 	return test_bit(IMG_REQ_LAYERED, &img_request->flags) != 0;
 }