From: Jens Freimann <jfreimann@redhat.com>
Date: Mon, 6 Nov 2017 14:05:46 +0000 (+0100)
Subject: net/socket: fix coverity issue
X-Git-Tag: v2.10.2~23
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=957bd48acfc350fd9b05669fb55cb61b004dd7bb;p=thirdparty%2Fqemu.git

net/socket: fix coverity issue

This fixes coverity issue CID1005339.

Make sure that saddr is not used uninitialized if the
mcast parameter is NULL.

Cc: qemu-stable@nongnu.org
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jens Freimann <jfreimann@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
(cherry picked from commit bb160b571fe469b03228d4502c75a18045978a74)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---

diff --git a/net/socket.c b/net/socket.c
index 18af2ab5f3d..6664a75aa4b 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -369,7 +369,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer,
     net_socket_read_poll(s, true);
 
     /* mcast: save bound address as dst */
-    if (is_connected) {
+    if (is_connected && mcast != NULL) {
         s->dgram_dst = saddr;
         snprintf(nc->info_str, sizeof(nc->info_str),
                  "socket: fd=%d (cloned mcast=%s:%d)",