From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 26 Mar 2020 02:05:19 +0000 (-0400)
Subject: Further fixes for ssl_passphrase_callback test module.
X-Git-Tag: REL_13_BETA1~457
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=958aa438aaa473d580f60154786ffd716a28faf2;p=thirdparty%2Fpostgresql.git

Further fixes for ssl_passphrase_callback test module.

The Makefile should set TAP_TESTS = 1, not implement the infrastructure
for itself.  For one thing, it missed the appropriate "make clean"
steps.  For another, the buildfarm isn't running this test because
it wasn't hooked into "make installcheck" either.
---

diff --git a/src/test/modules/ssl_passphrase_callback/Makefile b/src/test/modules/ssl_passphrase_callback/Makefile
index 1c4f79807e2..a3b518b50d4 100644
--- a/src/test/modules/ssl_passphrase_callback/Makefile
+++ b/src/test/modules/ssl_passphrase_callback/Makefile
@@ -1,4 +1,4 @@
-# ssl_passphrase Makefile
+# ssl_passphrase_callback Makefile
 
 export with_openssl
 
@@ -6,6 +6,8 @@ MODULE_big = ssl_passphrase_func
 OBJS = ssl_passphrase_func.o $(WIN32RES)
 PGFILEDESC = "callback function to provide a passphrase"
 
+TAP_TESTS = 1
+
 ifdef USE_PGXS
 PG_CONFIG = pg_config
 PGXS := $(shell $(PG_CONFIG) --pgxs)
@@ -18,9 +20,3 @@ include $(top_srcdir)/contrib/contrib-global.mk
 endif
 
 SHLIB_LINK += $(filter -lssl -lcrypto -lssleay32 -leay32, $(LIBS))
-
-check: prove-check
-
-prove-check: ssl_passphrase_func$(DLSUFFIX) | temp-install
-	@echo running prove ...
-	$(prove_check)