From: Zongmin Zhou <min_halo@163.com>
Date: Tue, 7 Nov 2023 02:44:17 +0000 (+0800)
Subject: dump: Add close fd on error return to avoid resource leak
X-Git-Tag: v8.2.0-rc0~19^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=95a40c44501b5e3b8d1922ea37f30142981b2b34;p=thirdparty%2Fqemu.git

dump: Add close fd on error return to avoid resource leak

Reported-by: Coverity CID 1523842 (RESOURCE_LEAK)
Fixes: e6549197f7 ("dump: Add command interface for kdump-raw formats")
Signed-off-by: Zongmin Zhou <zhouzongmin@kylinos.cn>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20231107024417.585475-1-min_halo@163.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---

diff --git a/dump/dump.c b/dump/dump.c
index 1c304cadfd1..ad5294e8536 100644
--- a/dump/dump.c
+++ b/dump/dump.c
@@ -2160,6 +2160,7 @@ void qmp_dump_guest_memory(bool paging, const char *protocol,
         return;
     }
     if (kdump_raw && lseek(fd, 0, SEEK_CUR) == (off_t) -1) {
+        close(fd);
         error_setg(errp, "kdump-raw formats require a seekable file");
         return;
     }