From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 27 Dec 2024 10:46:22 +0000 (+0100)
Subject: commit-reach: fix index used to loop through unsigned integer
X-Git-Tag: v2.49.0-rc0~104^2~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=95c09e4d07492fa9e4ad951a268b4ea6bae69038;p=thirdparty%2Fgit.git

commit-reach: fix index used to loop through unsigned integer

In 62e745ced2 (prio-queue: use size_t rather than int for size,
2024-12-20), we refactored `struct prio_queue` to track the number of
contained entries via a `size_t`. While the refactoring adapted one of
the users of that variable, it forgot to also adapt "commit-reach.c"
accordingly. This was missed because that file has -Wsign-conversion
disabled.

Fix the issue by using a `size_t` to iterate through entries.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/commit-reach.c b/commit-reach.c
index e3edd11995..e658726170 100644
--- a/commit-reach.c
+++ b/commit-reach.c
@@ -42,8 +42,7 @@ static int compare_commits_by_gen(const void *_a, const void *_b)
 
 static int queue_has_nonstale(struct prio_queue *queue)
 {
-	int i;
-	for (i = 0; i < queue->nr; i++) {
+	for (size_t i = 0; i < queue->nr; i++) {
 		struct commit *commit = queue->array[i].data;
 		if (!(commit->object.flags & STALE))
 			return 1;