From: rcombs <rcombs@rcombs.me>
Date: Wed, 8 Mar 2023 08:12:25 +0000 (-0600)
Subject: urlapi: avoid mutating internals in getter routine
X-Git-Tag: curl-8_0_0~80
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=95cb7d3166acca4cfe27526ee3feddd456b86684;p=thirdparty%2Fcurl.git

urlapi: avoid mutating internals in getter routine

This was not intended.

Closes #10708
---

diff --git a/lib/urlapi.c b/lib/urlapi.c
index c2caafbf0f..fca1fc74d7 100644
--- a/lib/urlapi.c
+++ b/lib/urlapi.c
@@ -1441,11 +1441,8 @@ CURLUcode curl_url_get(CURLU *u, CURLUPart what,
     break;
   case CURLUPART_PATH:
     ptr = u->path;
-    if(!ptr) {
-      ptr = u->path = strdup("/");
-      if(!u->path)
-        return CURLUE_OUT_OF_MEMORY;
-    }
+    if(!ptr)
+      ptr = "/";
     break;
   case CURLUPART_QUERY:
     ptr = u->query;
@@ -1555,8 +1552,7 @@ CURLUcode curl_url_get(CURLU *u, CURLUPart what,
               return CURLUE_OUT_OF_MEMORY;
             host++;
           }
-          free(u->host);
-          u->host = Curl_dyn_ptr(&enc);
+          allochost = Curl_dyn_ptr(&enc);
         }
       }