From: Nishka Dasgupta Date: Tue, 13 Aug 2019 06:33:55 +0000 (+0530) Subject: drm/aspeed: gfc_crtc: Make structure aspeed_gfx_funcs constant X-Git-Tag: v5.4-rc1~106^2~15^2~19 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=95cbf02b8a5d93d8404b5568ebf6862e87314ead;p=thirdparty%2Fkernel%2Flinux.git drm/aspeed: gfc_crtc: Make structure aspeed_gfx_funcs constant The static structure aspeed_gfx_funcs, of type drm_simple_display_pipe_funcs, is used only as an argument to drm_simple_display_pipe_init(), which does not modify it. Hence make it constant to protect it from unintended modification. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20190813063355.25549-1-nishkadg.linux@gmail.com --- diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c b/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c index 15db9e426ec42..2184b8be6fd4f 100644 --- a/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c @@ -215,7 +215,7 @@ static void aspeed_gfx_disable_vblank(struct drm_simple_display_pipe *pipe) writel(reg | CRT_CTRL_VERTICAL_INTR_STS, priv->base + CRT_CTRL1); } -static struct drm_simple_display_pipe_funcs aspeed_gfx_funcs = { +static const struct drm_simple_display_pipe_funcs aspeed_gfx_funcs = { .enable = aspeed_gfx_pipe_enable, .disable = aspeed_gfx_pipe_disable, .update = aspeed_gfx_pipe_update,