From: Volker Lendecke <vl@samba.org>
Date: Thu, 28 Nov 2024 11:19:27 +0000 (+0100)
Subject: libcli: Fix a signed/unsigned comparison warning
X-Git-Tag: tdb-1.4.13~423
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=963d54c8ee257e383b71bd32d41744a9764c4776;p=thirdparty%2Fsamba.git

libcli: Fix a signed/unsigned comparison warning

With this we compare pointers, not numbers

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Dec  2 05:52:56 UTC 2024 on atb-devel-224
---

diff --git a/libcli/security/claims-conversions.c b/libcli/security/claims-conversions.c
index 50b21f3085b..6983cb36f06 100644
--- a/libcli/security/claims-conversions.c
+++ b/libcli/security/claims-conversions.c
@@ -135,7 +135,7 @@ static bool blob_string_sid_to_sid(DATA_BLOB *blob,
 		return false;
 	}
 
-	if (end - str != len) {
+	if (str + len != end) {
 		return false;
 	}
 	return true;