From: Eric Blake <eblake@redhat.com>
Date: Tue, 31 Jul 2012 14:05:14 +0000 (-0600)
Subject: qemu: fix use after free
X-Git-Tag: v0.9.11.5~20
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9649b0a8b412220bd7696e0f200ab4c435302c18;p=thirdparty%2Flibvirt.git

qemu: fix use after free

Detected by Coverity.

* src/qemu/qemu_hotplug.c (qemuDomainAttachHostDevice): Avoid
double free of usb on failure.
(cherry picked from commit 665c8cdecc2d91a83f08a6ec95531b0de57c0e0a)
---

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 62de67c9f9..fcc7c0ff7d 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1170,6 +1170,7 @@ int qemuDomainAttachHostDevice(struct qemud_driver *driver,
 
         if (usbDeviceListAdd(list, usb) < 0) {
             usbFreeDevice(usb);
+            usb = NULL:
             goto cleanup;
         }