From: Joel Brobecker Date: Wed, 18 May 2011 17:29:59 +0000 (+0000) Subject: Remove one use of sprintf in ada-lang.c (print_it_exception) X-Git-Tag: sid-snapshot-20110601~142 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=967cff168cc01f56912a7ef9b4755c1502ad761c;p=thirdparty%2Fbinutils-gdb.git Remove one use of sprintf in ada-lang.c (print_it_exception) This is just a minor cleanup of an ARI violation. As this affects code that is normally unreachable (you'd need a runtime where the unit providing the exception hook has been compiled without debugging information), I tested this manually by commenting out the code just above, thus forcing this part of the code to be exercised. gdb/ChangeLog: * ada-lang.c (print_it_exception): Avoid use of sprintf. Tested on x86_64-linux. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index d7a31a6d917..0538dd7e6af 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2011-05-18 Joel Brobecker + + * ada-lang.c (print_it_exception): Avoid use of sprintf. + 2011-05-18 Tom Tromey * value.c (value_fn_field): Constify. diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index ebd5fd20700..0435d3396fe 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -10783,7 +10783,7 @@ print_it_exception (enum exception_catchpoint_kind ex, struct breakpoint *b) just replace the exception name by the generic string "exception" - it will read as "an exception" in the notification we are about to print. */ - sprintf (exception_name, "exception"); + memcpy (exception_name, "exception", sizeof ("exception")); } /* In the case of unhandled exception breakpoints, we print the exception name as "unhandled EXCEPTION_NAME", to make