From: Christian König Date: Thu, 5 Sep 2024 13:51:54 +0000 (+0200) Subject: dma-buf: add WARN_ON() illegal dma-fence signaling X-Git-Tag: v6.13-rc1~122^2~21^2~5 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=967d226eaae8e40636d257bf8ae55d2c5a912f58;p=thirdparty%2Fkernel%2Flinux.git dma-buf: add WARN_ON() illegal dma-fence signaling Calling the signaling a NULL fence is obviously a coding error in a driver. Those functions unfortunately just returned silently without raising a warning. Signed-off-by: Christian König Reviewed-by: Simona Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20240911085903.1496-2-christian.koenig@amd.com --- diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index f8303ae99acfd..f0cdd3e99d369 100644 --- a/drivers/dma-buf/dma-fence.c +++ b/drivers/dma-buf/dma-fence.c @@ -412,7 +412,7 @@ int dma_fence_signal_timestamp(struct dma_fence *fence, ktime_t timestamp) unsigned long flags; int ret; - if (!fence) + if (WARN_ON(!fence)) return -EINVAL; spin_lock_irqsave(fence->lock, flags); @@ -464,7 +464,7 @@ int dma_fence_signal(struct dma_fence *fence) int ret; bool tmp; - if (!fence) + if (WARN_ON(!fence)) return -EINVAL; tmp = dma_fence_begin_signalling();