From: Michael Paquier <michael@paquier.xyz>
Date: Sat, 8 May 2021 01:18:05 +0000 (+0900)
Subject: Fix incorrect error code for CREATE/ALTER TABLE COMPRESSION
X-Git-Tag: REL_14_BETA1~63
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9681f2160dcbe2a02fd2e2db2322ea204eff6562;p=thirdparty%2Fpostgresql.git

Fix incorrect error code for CREATE/ALTER TABLE COMPRESSION

Specifying an incorrect value for the compression method of an attribute
caused ERRCODE_FEATURE_NOT_SUPPORTED to be raised as error.  Use instead
ERRCODE_INVALID_PARAMETER_VALUE to be more consistent.

Author: Dilip Kumar
Discussion: https://postgr.es/m/CAFiTN-vH84fE-8C4zGZw4v0Wyh4Y2v=5JWg2fGE5+LPaDvz1GQ@mail.gmail.com
---

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 3b5d4116839..591bf01189b 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -18640,7 +18640,7 @@ GetAttributeCompression(Form_pg_attribute att, char *compression)
 	cmethod = CompressionNameToMethod(compression);
 	if (!CompressionMethodIsValid(cmethod))
 		ereport(ERROR,
-				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
 				 errmsg("invalid compression method \"%s\"", compression)));
 
 	return cmethod;