From: Steffan Karger <steffan.karger@foxcrypto.com>
Date: Tue, 7 Jul 2020 14:26:21 +0000 (+0200)
Subject: Make openvpn --version exit with exit code 0
X-Git-Tag: v2.5_beta1~87
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=96ae327add16f06ac8bc28cfbf9ba0abfcc7129c;p=thirdparty%2Fopenvpn.git

Make openvpn --version exit with exit code 0

For some reason, openvpn --version has since the beginning of time
returned exit code 1. A quick sample among common unix utilities confirms
that the rest of the world agrees with me that 0 makes more sense. Let's
make openvpn --version exit with exit code 0 too.

Signed-off-by: Steffan Karger <steffan.karger@foxcrypto.com>
Acked-by: Antonio Quartulli <antonio@openvpn.net>
Message-Id: <E1jsoYQ-0007AZ-BF@sfs-ml-1.v29.lw.sourceforge.com>
URL: https://www.mail-archive.com/search?l=mid&q=E1jsoYQ-0007AZ-BF@sfs-ml-1.v29.lw.sourceforge.com
Signed-off-by: Gert Doering <gert@greenie.muc.de>
---

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 2073b4a66..a72b677a9 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -4326,7 +4326,7 @@ usage_version(void)
     msg(M_INFO|M_NOPREFIX, "special build: %s", CONFIGURE_SPECIAL_BUILD);
 #endif
 #endif
-    openvpn_exit(OPENVPN_EXIT_STATUS_USAGE); /* exit point */
+    openvpn_exit(OPENVPN_EXIT_STATUS_GOOD);
 }
 
 void