From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 31 Oct 2023 10:45:28 +0000 (+0100)
Subject: dump: Fix g_array_unref(NULL) in dump-guest-memory
X-Git-Tag: v8.2.0-rc0~36^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=96afbc571c91b115ba51d9740352a0e45111edc9;p=thirdparty%2Fqemu.git

dump: Fix g_array_unref(NULL) in dump-guest-memory

When dump_init()'s check for non-zero @length fails, dump_cleanup()
passes null s->string_table_buf to g_array_unref(), which spews "GLib:
g_array_unref: assertion 'array' failed" to stderr.

Guard the g_array_unref().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20231031104531.3169721-3-armbru@redhat.com>
---

diff --git a/dump/dump.c b/dump/dump.c
index 9cdb4a2bf85..24c829e705d 100644
--- a/dump/dump.c
+++ b/dump/dump.c
@@ -100,7 +100,7 @@ static int dump_cleanup(DumpState *s)
     memory_mapping_list_free(&s->list);
     close(s->fd);
     g_free(s->guest_note);
-    g_array_unref(s->string_table_buf);
+    g_clear_pointer(&s->string_table_buf, g_array_unref);
     s->guest_note = NULL;
     if (s->resume) {
         if (s->detached) {