From: Frédéric Buclin <LpSolit@gmail.com>
Date: Tue, 3 Aug 2010 23:25:21 +0000 (+0200)
Subject: Bug 584110: Don't name attachment files "attachment.txt" by default, because this... 
X-Git-Tag: bugzilla-4.1.1~331
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=96b6cc3cf41f3fc657505d3bb6d2be9b65abe636;p=thirdparty%2Fbugzilla.git

Bug 584110: Don't name attachment files "attachment.txt" by default, because this confuses IE
a=LpSolit
---

diff --git a/attachment.cgi b/attachment.cgi
index 8e69d388fd..8117131b37 100755
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -481,7 +481,7 @@ sub insert {
          creation_ts   => $timestamp,
          data          => scalar $cgi->param('attach_text') || $cgi->upload('data'),
          description   => scalar $cgi->param('description'),
-         filename      => $cgi->param('attach_text') ? 'attachment.txt' : scalar $cgi->upload('data'),
+         filename      => $cgi->param('attach_text') ? "file_$bugid.txt" : scalar $cgi->upload('data'),
          ispatch       => scalar $cgi->param('ispatch'),
          isprivate     => scalar $cgi->param('isprivate'),
          mimetype      => $content_type,
diff --git a/post_bug.cgi b/post_bug.cgi
index 74d26af2b6..2c8062605f 100755
--- a/post_bug.cgi
+++ b/post_bug.cgi
@@ -200,7 +200,7 @@ if (defined($cgi->upload('data')) || $cgi->param('attach_text')) {
              creation_ts   => $timestamp,
              data          => scalar $cgi->param('attach_text') || $cgi->upload('data'),
              description   => scalar $cgi->param('description'),
-             filename      => $cgi->param('attach_text') ? 'attachment.txt' : scalar $cgi->upload('data'),
+             filename      => $cgi->param('attach_text') ? "file_$id.txt" : scalar $cgi->upload('data'),
              ispatch       => scalar $cgi->param('ispatch'),
              isprivate     => scalar $cgi->param('isprivate'),
              mimetype      => $content_type,