From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 20 Apr 2020 15:03:18 +0000 (+0200)
Subject: mqtt: fix Curl_read()  error handling while reading remaining length
X-Git-Tag: curl-7_70_0~31
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=96c149685bff881b30493acf0fed1fc4cd5520ee;p=thirdparty%2Fcurl.git

mqtt: fix Curl_read()  error handling while reading remaining length

Detected by Coverity. CID 1462320.

Closes #5274
---

diff --git a/lib/mqtt.c b/lib/mqtt.c
index 35c1b3e833..44433361b3 100644
--- a/lib/mqtt.c
+++ b/lib/mqtt.c
@@ -569,6 +569,8 @@ static CURLcode mqtt_doing(struct connectdata *conn, bool *done)
         Curl_debug(data, CURLINFO_HEADER_IN, (char *)&byte, 1);
       pkt[mq->npacket++] = byte;
     } while((byte & 0x80) && (mq->npacket < 4));
+    if(result)
+      break;
     mq->remaining_length = mqtt_decode_len(&pkt[0], mq->npacket, NULL);
     mq->npacket = 0;
     if(mq->remaining_length) {