From: stephan <stephan@noemail.net>
Date: Thu, 3 Aug 2023 16:02:30 +0000 (+0000)
Subject: Fix a discrepancy between sqlite3_values_to_js() and its API docs/intended behavior.
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=96f6cd5cab13334a1182feba333cc236a6ce8f7c;p=thirdparty%2Fsqlite.git

Fix a discrepancy between sqlite3_values_to_js() and its API docs/intended behavior.

FossilOrigin-Name: 16658b3c64d7f9690b097d999a8fbdc49dedf484f72174059718a768f61e875b
---

diff --git a/ext/wasm/api/sqlite3-api-prologue.js b/ext/wasm/api/sqlite3-api-prologue.js
index 0179091c02..3b29041c37 100644
--- a/ext/wasm/api/sqlite3-api-prologue.js
+++ b/ext/wasm/api/sqlite3-api-prologue.js
@@ -1645,7 +1645,8 @@ globalThis.sqlite3ApiBootstrap = function sqlite3ApiBootstrap(
          do not.
       */
       tgt.push(capi.sqlite3_value_to_js(
-        wasm.peekPtr(pArgv + (wasm.ptrSizeof * i))
+        wasm.peekPtr(pArgv + (wasm.ptrSizeof * i)),
+        throwIfCannotConvert
       ));
     }
     return tgt;
diff --git a/manifest b/manifest
index 0d4d289c90..7dc9860aa3 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Initial\swork\son\sexposing\sthe\sFTS5\sAPIs\sto\swasm,\sper\s[forum:28402061cb|request\sin\sthe\sforum].\sThis\sbuilds\sand\sloads\sthe\sstructs\sinto\sJS\sbut\sis\scompletely\suntested.
-D 2023-08-03T07:20:10.366
+C Fix\sa\sdiscrepancy\sbetween\ssqlite3_values_to_js()\sand\sits\sAPI\sdocs/intended\sbehavior.
+D 2023-08-03T16:02:30.143
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -502,7 +502,7 @@ F ext/wasm/api/pre-js.c-pp.js ad906703f7429590f2fbf5e6498513bf727a1a4f0ebfa057af
 F ext/wasm/api/sqlite3-api-cleanup.js d235ad237df6954145404305040991c72ef8b1881715d2a650dda7b3c2576d0e
 F ext/wasm/api/sqlite3-api-glue.js 8d087ebb00d1db2afa393b9ea7bfe1ec1fd7387c566d9bb160119e66dd8c2d04
 F ext/wasm/api/sqlite3-api-oo1.js 9678dc4d9a5d39632b6ffe6ea94a023119260815bf32f265bf5f6c36c9516db8
-F ext/wasm/api/sqlite3-api-prologue.js cbd7d6ba185f3a844a8b0020e954b49bbc2ca78b305d117bec2ceca21431795a
+F ext/wasm/api/sqlite3-api-prologue.js 76258e160bf6a89cc75a7d3c05646a054c8cab7219cd1e10bc20cacaad022131
 F ext/wasm/api/sqlite3-api-worker1.js 9f32af64df1a031071912eea7a201557fe39b1738645c0134562bb84e88e2fec
 F ext/wasm/api/sqlite3-license-version-header.js 0c807a421f0187e778dc1078f10d2994b915123c1223fe752b60afdcd1263f89
 F ext/wasm/api/sqlite3-opfs-async-proxy.js 8cf8a897726f14071fae6be6648125162b256dfb4f96555b865dbb7a6b65e379
@@ -2049,11 +2049,8 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P ea0b9aecbaca9a8e784fd2bcb50f78cbdcf4c5cfb45a7700bb222e4cc104c644
-R 334f0a59a542a8edf0f33116c4ce928b
-T *branch * wasm-fts5
-T *sym-wasm-fts5 *
-T -sym-trunk * Cancelled\sby\sbranch.
+P 52c8b73ae3095b7e9f4d5440169c818677e484d85195036a0d82db0d04a428e5
+R f66e2e5bbfcc0156634777fa6a1a3cf0
 U stephan
-Z 7b32e66e5dffca6facb4b18e26761abd
+Z 6955fafa5414b6323f1535856f263b13
 # Remove this line to create a well-formed Fossil manifest.
diff --git a/manifest.uuid b/manifest.uuid
index 654bb314cb..f413a0221e 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-52c8b73ae3095b7e9f4d5440169c818677e484d85195036a0d82db0d04a428e5
\ No newline at end of file
+16658b3c64d7f9690b097d999a8fbdc49dedf484f72174059718a768f61e875b
\ No newline at end of file