From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 3 Jun 2024 19:46:51 +0000 (+0300)
Subject: doveadm save: Fix potential assert-crash if saving failed
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=97791e1ea53fdff64bafef6ff572b237b41dbe3b;p=thirdparty%2Fdovecot%2Fcore.git

doveadm save: Fix potential assert-crash if saving failed

The input stream may not have been fully read at failure time.

Fixes:
Panic: file doveadm-mail-save.c: line 91 (cmd_save_to_mailbox): assertion failed: (input->eof)
---

diff --git a/src/doveadm/doveadm-mail-save.c b/src/doveadm/doveadm-mail-save.c
index d8312c8227..dff2abe071 100644
--- a/src/doveadm/doveadm-mail-save.c
+++ b/src/doveadm/doveadm-mail-save.c
@@ -77,7 +77,7 @@ cmd_save_to_mailbox(struct save_cmd_context *ctx, struct mailbox *box,
 		mailbox_save_cancel(&save_ctx);
 	if (trans != NULL)
 		mailbox_transaction_rollback(&trans);
-	i_assert(input->eof);
+	i_assert(ret < 0 || input->eof);
 	return ret < 0 ? -1 : 0;
 }