From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date: Sun, 10 Nov 2024 13:04:47 +0000 (+0100)
Subject: thermal: testing: Simplify tt_get_tt_zone()
X-Git-Tag: v6.13-rc1~193^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9782dd101f343d7f1cad824dc26ad355341e1f3b;p=thirdparty%2Fkernel%2Flinux.git

thermal: testing: Simplify tt_get_tt_zone()

Notice that tt_get_tt_zone() need not use the ret variable in
the tt_thermal_zones list walk and make it return right after
incrementing the reference counter of the matching entry.

No functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/6120304.lOV4Wx5bFT@rjwysocki.net
---

diff --git a/drivers/thermal/testing/zone.c b/drivers/thermal/testing/zone.c
index c6d8c66f40f98..fb83d2501284d 100644
--- a/drivers/thermal/testing/zone.c
+++ b/drivers/thermal/testing/zone.c
@@ -288,19 +288,14 @@ static struct tt_thermal_zone *tt_get_tt_zone(const char *arg)
 
 	guard(mutex)(&tt_thermal_zones_lock);
 
-	ret = -EINVAL;
 	list_for_each_entry(tt_zone, &tt_thermal_zones, list_node) {
 		if (tt_zone->id == id) {
 			tt_zone->refcount++;
-			ret = 0;
-			break;
+			return tt_zone;
 		}
 	}
 
-	if (ret)
-		return ERR_PTR(ret);
-
-	return tt_zone;
+	return ERR_PTR(-EINVAL);
 }
 
 static void tt_put_tt_zone(struct tt_thermal_zone *tt_zone)