From: Tom Tromey <tromey@adacore.com>
Date: Wed, 5 Jun 2024 16:38:10 +0000 (-0600)
Subject: Prefer htab_traverse_noresize
X-Git-Tag: binutils-2_43~299
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=979114a1b39cbcbe61faeaf9fe65ead589ea1096;p=thirdparty%2Fbinutils-gdb.git

Prefer htab_traverse_noresize

A few spots in gdb were using htab_traverse.  IMO this is almost never
useful and htab_traverse_noresize should be preferred.
---

diff --git a/gdb/completer.c b/gdb/completer.c
index f1f44109bdc..bd5118f53c5 100644
--- a/gdb/completer.c
+++ b/gdb/completer.c
@@ -2058,7 +2058,7 @@ completion_tracker::recompute_lowest_common_denominator ()
 	return 1;
       };
 
-  htab_traverse (m_entries_hash.get (), visitor_func, this);
+  htab_traverse_noresize (m_entries_hash.get (), visitor_func, this);
   m_lowest_common_denominator_valid = true;
 }
 
diff --git a/gdb/dwarf2/cu.c b/gdb/dwarf2/cu.c
index aae61cccd21..5cb22919c32 100644
--- a/gdb/dwarf2/cu.c
+++ b/gdb/dwarf2/cu.c
@@ -146,7 +146,8 @@ dwarf2_cu::mark ()
     {
       m_mark = true;
       if (m_dependencies != nullptr)
-	htab_traverse (m_dependencies.get (), dwarf2_mark_helper, per_objfile);
+	htab_traverse_noresize (m_dependencies.get (), dwarf2_mark_helper,
+				per_objfile);
     }
 }
 
diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c
index cb9a91d0923..7e272c719c3 100644
--- a/gdb/gdb_bfd.c
+++ b/gdb/gdb_bfd.c
@@ -1200,7 +1200,7 @@ maintenance_info_bfds (const char *arg, int from_tty)
   uiout->table_header (40, ui_left, "filename", "Filename");
 
   uiout->table_body ();
-  htab_traverse (all_bfds, print_one_bfd, uiout);
+  htab_traverse_noresize (all_bfds, print_one_bfd, uiout);
 }
 
 /* BFD related per-inferior data.  */