From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 21 Aug 2019 11:05:16 +0000 (+0200)
Subject: qemu: Fix retval if ACL check fails in qemuNodeGetSecurityModel
X-Git-Tag: v7.0.0-rc1~119
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=97bc56d75f5952d799b541d943851716246d6613;p=thirdparty%2Flibvirt.git

qemu: Fix retval if ACL check fails in qemuNodeGetSecurityModel

While previously we returned 0 this is not correct. We have to
return a negative value to indicate error.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 96ec84bd1c..88324945ef 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5935,7 +5935,7 @@ static int qemuNodeGetSecurityModel(virConnectPtr conn,
     memset(secmodel, 0, sizeof(*secmodel));
 
     if (virNodeGetSecurityModelEnsureACL(conn) < 0)
-        return 0;
+        return -1;
 
     /* We treat no driver as success, but simply return no data in *secmodel */
     if (!(caps = virQEMUDriverGetCapabilities(driver, false)) ||