From: Hans de Goede Date: Tue, 27 Aug 2024 10:52:48 +0000 (+0200) Subject: Bluetooth: Use led_set_brightness() in LED trigger activate() callback X-Git-Tag: v6.12-rc1~232^2~19^2~9 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=97c7ed86322440131f834d34c6670d1d472901dd;p=thirdparty%2Fkernel%2Flinux.git Bluetooth: Use led_set_brightness() in LED trigger activate() callback A LED trigger's activate() callback gets called when the LED trigger gets activated for a specific LED, so that the trigger code can ensure the LED state matches the current state of the trigger condition (LED_FULL when HCI_UP is set in this case). led_trigger_event() is intended for trigger condition state changes and iterates over _all_ LEDs which are controlled by this trigger changing the brightness of each of them. In the activate() case only the brightness of the LED which is being activated needs to change and that LED is passed as an argument to activate(), switch to led_set_brightness() to only change the brightness of the LED being activated. Signed-off-by: Hans de Goede Signed-off-by: Luiz Augusto von Dentz --- diff --git a/net/bluetooth/leds.c b/net/bluetooth/leds.c index f46847632ffa1..6e349704efe47 100644 --- a/net/bluetooth/leds.c +++ b/net/bluetooth/leds.c @@ -48,7 +48,7 @@ static int power_activate(struct led_classdev *led_cdev) htrig = to_hci_basic_led_trigger(led_cdev->trigger); powered = test_bit(HCI_UP, &htrig->hdev->flags); - led_trigger_event(led_cdev->trigger, powered ? LED_FULL : LED_OFF); + led_set_brightness(led_cdev, powered ? LED_FULL : LED_OFF); return 0; }