From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 29 Jan 2021 16:02:03 +0000 (+0100)
Subject: dnsdist: Silence a 'performance' warning from cppcheck
X-Git-Tag: dnsdist-1.6.0-alpha1~1^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=986b684aaa4ac61a2442046f08fbc1b65f4de98a;p=thirdparty%2Fpdns.git

dnsdist: Silence a 'performance' warning from cppcheck
---

diff --git a/pdns/dnsdistdist/tcpiohandler.cc b/pdns/dnsdistdist/tcpiohandler.cc
index 7c9aae7c53..e308e2791b 100644
--- a/pdns/dnsdistdist/tcpiohandler.cc
+++ b/pdns/dnsdistdist/tcpiohandler.cc
@@ -294,10 +294,8 @@ int OpenSSLTLSConnection::s_tlsConnIndex = -1;
 class OpenSSLTLSIOCtx: public TLSCtx
 {
 public:
-  OpenSSLTLSIOCtx(TLSFrontend& fe)
+  OpenSSLTLSIOCtx(TLSFrontend& fe): d_feContext(std::make_shared<OpenSSLFrontendContext>(fe.d_addr, fe.d_tlsConfig))
   {
-    d_feContext = std::make_shared<OpenSSLFrontendContext>(fe.d_addr, fe.d_tlsConfig);
-
     d_ticketsKeyRotationDelay = fe.d_tlsConfig.d_ticketsKeyRotationDelay;
 
     if (fe.d_tlsConfig.d_enableTickets && fe.d_tlsConfig.d_numberOfTicketsKeys > 0) {