From: Bin Liu Date: Wed, 13 May 2020 21:36:46 +0000 (-0500) Subject: USB: serial: usb_wwan: do not resubmit rx urb on fatal errors X-Git-Tag: v5.8-rc1~108^2~6^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=986c1748c84d7727defeaeca74a73b37f7d5cce1;p=thirdparty%2Flinux.git USB: serial: usb_wwan: do not resubmit rx urb on fatal errors usb_wwan_indat_callback() shouldn't resubmit rx urb if the previous urb status is a fatal error. Or the usb controller would keep processing the new urbs then run into interrupt storm, and has no chance to recover. Fixes: 6c1ee66a0b2b ("USB-Serial: Fix error handling of usb_wwan") Cc: stable@vger.kernel.org Signed-off-by: Bin Liu Signed-off-by: Johan Hovold --- diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c index 13be21aad2f40..4b9845807bee1 100644 --- a/drivers/usb/serial/usb_wwan.c +++ b/drivers/usb/serial/usb_wwan.c @@ -270,6 +270,10 @@ static void usb_wwan_indat_callback(struct urb *urb) if (status) { dev_dbg(dev, "%s: nonzero status: %d on endpoint %02x.\n", __func__, status, endpoint); + + /* don't resubmit on fatal errors */ + if (status == -ESHUTDOWN || status == -ENOENT) + return; } else { if (urb->actual_length) { tty_insert_flip_string(&port->port, data,