From: Aaron Merey <amerey@redhat.com>
Date: Wed, 28 Sep 2022 14:04:23 +0000 (-0400)
Subject: debuginfod-client: Ensure only negative error codes returned.
X-Git-Tag: elfutils-0.188~25
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9891b6117b836b60830c03c0297d83597f319dbc;p=thirdparty%2Felfutils.git

debuginfod-client: Ensure only negative error codes returned.

Switch a couple error codes from positive to negative so they aren't
interpreted as file descriptors by the caller.
---

diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
index 680720ff8..8fb65133f 100644
--- a/debuginfod/ChangeLog
+++ b/debuginfod/ChangeLog
@@ -1,3 +1,8 @@
+2022-09-28  Aaron Merey  <amerey@redhat.com>
+
+	* debuginfod-client.c (debuginfod_query_server): Switch sign of some
+	error codes from positive to negative.
+
 2022-09-08  Frank Ch. Eigler  <fche@redhat.com>
 
 	* debuginfod-client.c (debuginfod_query_server): Clear
diff --git a/debuginfod/debuginfod-client.c b/debuginfod/debuginfod-client.c
index 28ad04c06..2a14d9d96 100644
--- a/debuginfod/debuginfod-client.c
+++ b/debuginfod/debuginfod-client.c
@@ -1085,7 +1085,7 @@ debuginfod_query_server (debuginfod_client *c,
   c->winning_headers = NULL;
   if ( maxtime > 0 && clock_gettime(CLOCK_MONOTONIC_RAW, &start_time) == -1)
     {
-      rc = errno;
+      rc = -errno;
       goto out2;
     }
   long delta = 0;
@@ -1096,7 +1096,7 @@ debuginfod_query_server (debuginfod_client *c,
         {
           if (clock_gettime(CLOCK_MONOTONIC_RAW, &cur_time) == -1)
             {
-              rc = errno;
+              rc = -errno;
               goto out2;
             }
           delta = cur_time.tv_sec - start_time.tv_sec;