From: Willy Tarreau <w@1wt.eu>
Date: Tue, 29 Apr 2025 10:05:08 +0000 (+0200)
Subject: BUG/MINOR: mux-h2: fix the offset of the pattern for the ping frame
X-Git-Tag: v3.2-dev13~49
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=989f609b1a1cd0d7717864c8dad2d833d018208a;p=thirdparty%2Fhaproxy.git

BUG/MINOR: mux-h2: fix the offset of the pattern for the ping frame

The ping frame's pattern must be written at offset 9 (frame header
length), not 8. This was added in 3.2 with commit 4dcfe098a6 ("MINOR:
mux-h2: prepare to support PING emission"), so no backport is needed.
---

diff --git a/src/mux_h2.c b/src/mux_h2.c
index e739c8aee..9bec15030 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -3155,7 +3155,7 @@ static int h2c_send_ping(struct h2c *h2c, int ack)
 		       "\x00\x00\x00\x00" /* stream ID */, 9);
 
 		/* opaque data */
-		memcpy(str + 8, "\x00\x01\x02\x03\x04\x05\x06\x07", 8);
+		memcpy(str + 9, "\x00\x01\x02\x03\x04\x05\x06\x07", 8);
 	}
 	else {
 		if (b_data(&h2c->dbuf) < 8) {