From: Phil Sutter Date: Thu, 5 Dec 2019 12:15:01 +0000 (+0100) Subject: extensions: time: Avoid undefined shift X-Git-Tag: v1.8.5~79 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=98b221002960040bf3505811c06025b6b9b6984b;p=thirdparty%2Fiptables.git extensions: time: Avoid undefined shift Value 1 is signed by default and left-shifting by 31 is undefined for those. Fix this by marking the value as unsigned. Fixes: ad326ef9f734a ("Add the libxt_time iptables match") --- diff --git a/extensions/libxt_time.c b/extensions/libxt_time.c index 5a8cc5de..d001f5b7 100644 --- a/extensions/libxt_time.c +++ b/extensions/libxt_time.c @@ -330,7 +330,7 @@ static void time_print_monthdays(uint32_t mask, bool human_readable) printf(" "); for (i = 1; i <= 31; ++i) - if (mask & (1 << i)) { + if (mask & (1u << i)) { if (nbdays++ > 0) printf(","); printf("%u", i);