From: René Scharfe Date: Sun, 23 Mar 2025 09:53:21 +0000 (+0100) Subject: commit: move clear_commit_marks_many() loop body to clear_commit_marks() X-Git-Tag: v2.50.0-rc0~134^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=98b423bc1c8a0ff93004deb56571553847276103;p=thirdparty%2Fgit.git commit: move clear_commit_marks_many() loop body to clear_commit_marks() clear_commit_marks_many() clears multiple commits one by one. Move the code for handling a single commit to clear_commit_marks() and call it instead of the other way around, to simplify the code. Signed-off-by: René Scharfe Signed-off-by: Junio C Hamano --- diff --git a/commit.c b/commit.c index 6efdb03997..425503bb9f 100644 --- a/commit.c +++ b/commit.c @@ -780,19 +780,17 @@ static void clear_commit_marks_1(struct commit_list **plist, void clear_commit_marks_many(size_t nr, struct commit **commit, unsigned int mark) { - for (size_t i = 0; i < nr; i++) { - struct commit_list *list = NULL; - - clear_commit_marks_1(&list, *commit, mark); - while (list) - clear_commit_marks_1(&list, pop_commit(&list), mark); - commit++; - } + for (size_t i = 0; i < nr; i++) + clear_commit_marks(commit[i], mark); } void clear_commit_marks(struct commit *commit, unsigned int mark) { - clear_commit_marks_many(1, &commit, mark); + struct commit_list *list = NULL; + + clear_commit_marks_1(&list, commit, mark); + while (list) + clear_commit_marks_1(&list, pop_commit(&list), mark); } struct commit *pop_commit(struct commit_list **stack)