From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Fri, 12 Nov 2021 09:43:16 +0000 (+0100)
Subject: lib-storage: mail-duplicate - Fix panic occurring when user has no configured home... 
X-Git-Tag: 2.3.18~117
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=98f709deac9381721b93d896c27576dbff1f711c;p=thirdparty%2Fdovecot%2Fcore.git

lib-storage: mail-duplicate - Fix panic occurring when user has no configured home directory.

Panic was:

Panic: file imem.c: line 65 (i_strconcat): assertion failed: (str1 != NULL)
---

diff --git a/src/lib-storage/mail-duplicate.c b/src/lib-storage/mail-duplicate.c
index ff4fa5630b..407fe4aec9 100644
--- a/src/lib-storage/mail-duplicate.c
+++ b/src/lib-storage/mail-duplicate.c
@@ -722,14 +722,17 @@ mail_duplicate_db_init(struct mail_user *user, const char *name)
 
 	e_debug(db->event, "Initialize");
 
+	db->user = user;
+
 	if (mail_user_get_home(user, &home) <= 0) {
 		e_error(db->event, "User %s doesn't have home dir set, "
 			"disabling duplicate database", user->username);
+		return db;
 	}
 
-	db->user = user;
-	db->path = home == NULL ? NULL :
-		i_strconcat(home, "/.dovecot.", name, NULL);
+	i_assert(home != NULL);
+
+	db->path = i_strconcat(home, "/.dovecot.", name, NULL);
 	db->dotlock_set = default_mail_duplicate_dotlock_set;
 
 	lock_dir = mail_user_get_volatile_dir(user);