From: Andrew Burgess <aburgess@redhat.com>
Date: Tue, 6 May 2025 15:55:44 +0000 (+0100)
Subject: Revert "gdb: support zero inode in generate-core-file command"
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=998165ba99a;p=thirdparty%2Fbinutils-gdb.git

Revert "gdb: support zero inode in generate-core-file command"

This reverts commit 1e21c846c275fc6e387ca903a129096be2a53d0b.

This change was causing unexpected mappings to be included in the core
files generated by GDB, which was triggering warnings when GDB opened
a core file, like this:

  warning: Can't open file [stack] during file-backed mapping note processing

  warning: Can't open file [vvar] during file-backed mapping note processing

For now I'm reverting the above commit and will come to the list again
when I have a solution that addresses the original issue without also
including the unexpected mappings.
---

diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
index a03f9315560..bbffb3d1c90 100644
--- a/gdb/linux-tdep.c
+++ b/gdb/linux-tdep.c
@@ -1712,7 +1712,7 @@ linux_make_mappings_callback (ULONGEST vaddr, ULONGEST size,
     = (struct linux_make_mappings_data *) data;
   gdb_byte buf[sizeof (ULONGEST)];
 
-  if (*filename == '\0')
+  if (*filename == '\0' || inode == 0)
     return 0;
 
   ++map_data->file_count;