From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Fri, 7 Jan 2022 13:32:31 +0000 (+0100)
Subject: MINOR: quic: Non-optimal use of a TX buffer
X-Git-Tag: v2.6-dev1~157
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=99942d6f4c4dc91a2e5227a6915e789fd8c12331;p=thirdparty%2Fhaproxy.git

MINOR: quic: Non-optimal use of a TX buffer

When full, after having reset the writer index, let's reuse the TX buffer in
any case.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index f1adc19a8e..836e83f4c6 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -2450,9 +2450,9 @@ static int qc_prep_pkts(struct quic_conn *qc, struct qring *qr,
 
 	TRACE_ENTER(QUIC_EV_CONN_PHPKTS, qc);
 
+	total = 0;
  start:
 	dglen = 0;
-	total = 0;
 	padding = 0;
 	qel = &qc->els[tel];
 	cbuf = qr->cbuf;
@@ -2603,10 +2603,8 @@ static int qc_prep_pkts(struct quic_conn *qc, struct qring *qr,
 
 	    if (rd && rd <= cbuf->wr) {
 			cb_wr_reset(cbuf);
-			if (pos == spos) {
-				/* Reuse the same buffer if nothing was built. */
-				goto start;
-			}
+			/* Let's try to reuse this buffer */
+			goto start;
 		}
 	}