From: Stefan Hajnoczi Date: Tue, 16 May 2023 19:02:26 +0000 (-0400) Subject: hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore X-Git-Tag: v8.1.0-rc0~87^2~12 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9998f70f6625f15f2ae36f612509ea34733c11d3;p=thirdparty%2Fqemu.git hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore There is no need to suspend activity between aio_disable_external() and aio_enable_external(), which is mainly used for the block layer's drain operation. This is part of ongoing work to remove the aio_disable_external() API. Reviewed-by: David Woodhouse Reviewed-by: Paul Durrant Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf Message-Id: <20230516190238.8401-9-stefanha@redhat.com> Signed-off-by: Kevin Wolf --- diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c index 900679af8a1..6e81bc8791c 100644 --- a/hw/i386/kvm/xen_xenstore.c +++ b/hw/i386/kvm/xen_xenstore.c @@ -133,7 +133,7 @@ static void xen_xenstore_realize(DeviceState *dev, Error **errp) error_setg(errp, "Xenstore evtchn port init failed"); return; } - aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), true, + aio_set_fd_handler(qemu_get_aio_context(), xen_be_evtchn_fd(s->eh), false, xen_xenstore_event, NULL, NULL, NULL, s); s->impl = xs_impl_create(xen_domid);