From: Jan Kratochvil <jan.kratochvil@redhat.com>
Date: Thu, 21 Nov 2013 14:33:22 +0000 (+0100)
Subject: Fix non-build-id core files on build-id system
X-Git-Tag: elfutils-0.158~57
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=99a29497c673871040fed2382938eb5bd06befdd;p=thirdparty%2Felfutils.git

Fix non-build-id core files on build-id system

Signed-off-by: Jan Kratochvil <jan.kratochvil@redhat.com>
---

diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index 3c2ffc814..deb501407 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,9 @@
+2013-11-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	Fix non-build-id core files on build-id system.
+	* link_map.c (report_r_debug): Remove valid clearing if build-id cannot
+	be read from memory.
+
 2013-11-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	* dwfl_segment_report_module.c (dwfl_segment_report_module): New
diff --git a/libdwfl/link_map.c b/libdwfl/link_map.c
index b30f2e37a..2913d9f73 100644
--- a/libdwfl/link_map.c
+++ b/libdwfl/link_map.c
@@ -415,9 +415,11 @@ report_r_debug (uint_fast8_t elfclass, uint_fast8_t elfdata,
 						&buffer, &buffer_available,
 						build_id_vaddr, build_id_len,
 						memory_callback_arg))
-			/* File has valid build-id which cannot be verified
-			   in memory.  */
-			valid = false;
+			{
+			  /* File has valid build-id which cannot be read from
+			     memory.  This happens for core files without bit 4
+			     (0x10) set in Linux /proc/PID/coredump_filter.  */
+			}
 		      else
 			{
 			  if (memcmp (build_id_bits, buffer, build_id_len) != 0)