From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Fri, 9 Jun 2017 18:17:30 +0000 (+0200)
Subject: revision.c: stricter parsing of '--no-{min,max}-parents'
X-Git-Tag: v2.13.2~4^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9ada7aee198c3644604eac1ff7cc50284b48d85f;p=thirdparty%2Fgit.git

revision.c: stricter parsing of '--no-{min,max}-parents'

These two options are parsed using starts_with(), allowing things like
'git log --no-min-parents-foobarbaz' to succeed.

Use strcmp() instead.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/revision.c b/revision.c
index b37dbec378..8a40cc7b34 100644
--- a/revision.c
+++ b/revision.c
@@ -1777,11 +1777,11 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg
 		revs->max_parents = 1;
 	} else if (starts_with(arg, "--min-parents=")) {
 		revs->min_parents = atoi(arg+14);
-	} else if (starts_with(arg, "--no-min-parents")) {
+	} else if (!strcmp(arg, "--no-min-parents")) {
 		revs->min_parents = 0;
 	} else if (starts_with(arg, "--max-parents=")) {
 		revs->max_parents = atoi(arg+14);
-	} else if (starts_with(arg, "--no-max-parents")) {
+	} else if (!strcmp(arg, "--no-max-parents")) {
 		revs->max_parents = -1;
 	} else if (!strcmp(arg, "--boundary")) {
 		revs->boundary = 1;