From: Guenter Roeck Date: Tue, 26 Mar 2019 20:29:12 +0000 (-0700) Subject: platform/x86: intel_pmc_core: Mark local function static X-Git-Tag: v5.2-rc1~96^2~20 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9ae11e237d951f52a7c0e1a404dc7dd4ae1ee4fa;p=thirdparty%2Fkernel%2Flinux.git platform/x86: intel_pmc_core: Mark local function static 0day reports: drivers/platform/x86/intel_pmc_core.c:833:5: sparse: symbol 'quirk_xtal_ignore' was not declared. Should it be static? Mark the function static since it is indeed only called locally. Cc: Rajneesh Bhardwaj Fixes: 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown") Signed-off-by: Guenter Roeck Signed-off-by: Andy Shevchenko --- diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c index f2c621b55f497..9908d233305e4 100644 --- a/drivers/platform/x86/intel_pmc_core.c +++ b/drivers/platform/x86/intel_pmc_core.c @@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = { * the platform BIOS enforces 24Mhx Crystal to shutdown * before PMC can assert SLP_S0#. */ -int quirk_xtal_ignore(const struct dmi_system_id *id) +static int quirk_xtal_ignore(const struct dmi_system_id *id) { struct pmc_dev *pmcdev = &pmc; u32 value;