From: Zichen Xie <zichenxie0106@gmail.com>
Date: Wed, 23 Oct 2024 21:13:10 +0000 (-0500)
Subject: mtd: diskonchip: Cast an operand to prevent potential overflow
X-Git-Tag: v6.13-rc5~22^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9b458e8be0d13e81ed03fffa23f8f9b528bbd786;p=thirdparty%2Fkernel%2Flinux.git

mtd: diskonchip: Cast an operand to prevent potential overflow

There may be a potential integer overflow issue in inftl_partscan().
parts[0].size is defined as "uint64_t"  while mtd->erasesize and
ip->firstUnit are defined as 32-bit unsigned integer. The result of
the calculation will be limited to 32 bits without correct casting.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Zichen Xie <zichenxie0106@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---

diff --git a/drivers/mtd/nand/raw/diskonchip.c b/drivers/mtd/nand/raw/diskonchip.c
index 8db7fc4245711..70d6c2250f32c 100644
--- a/drivers/mtd/nand/raw/diskonchip.c
+++ b/drivers/mtd/nand/raw/diskonchip.c
@@ -1098,7 +1098,7 @@ static inline int __init inftl_partscan(struct mtd_info *mtd, struct mtd_partiti
 		    (i == 0) && (ip->firstUnit > 0)) {
 			parts[0].name = " DiskOnChip IPL / Media Header partition";
 			parts[0].offset = 0;
-			parts[0].size = mtd->erasesize * ip->firstUnit;
+			parts[0].size = (uint64_t)mtd->erasesize * ip->firstUnit;
 			numparts = 1;
 		}