From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Fri, 15 Sep 2017 08:49:16 +0000 (+0300)
Subject: lib: uri_parser_init*() - initialize allow_pct_nul
X-Git-Tag: 2.3.0.rc1~1010
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9bea325875d114ff90529cc8f1e8ff89fc4fe700;p=thirdparty%2Fdovecot%2Fcore.git

lib: uri_parser_init*() - initialize allow_pct_nul

Unless the caller explicitly cleared the parser's memory, allow_pct_nul was
somewhat random. All the code in Dovecot core did this, but some plugins
didn't.
---

diff --git a/src/lib/uri-util.c b/src/lib/uri-util.c
index 5ddafd3df8..6f30fa3c80 100644
--- a/src/lib/uri-util.c
+++ b/src/lib/uri-util.c
@@ -1051,12 +1051,10 @@ int uri_parse_fragment(struct uri_parser *parser, const char **fragment_r)
 void uri_parser_init_data(struct uri_parser *parser,
 	pool_t pool, const unsigned char *data, size_t size)
 {
+	i_zero(parser);
 	parser->pool = pool;
 	parser->begin = parser->cur = data;
 	parser->end = data + size;
-	parser->error = NULL;
-	parser->tmpbuf = NULL;
-
 }
 
 void uri_parser_init(struct uri_parser *parser,