From: Frank Lichtenheld <frank@lichtenheld.com>
Date: Tue, 23 Sep 2025 12:20:00 +0000 (+0200)
Subject: configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend
X-Git-Tag: v2.7_beta2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9bfd4d246c50743c8ff9cdb72afc8741eab91f03;p=thirdparty%2Fopenvpn.git

configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend

The prepend behavior is surprising. If there is a difference
in behavior at least make it easy to understand what happens
why.

Change-Id: I1ce408d4473874d88a348308503527ef7eb8c1ff
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1204
Message-Id: <20250923122006.12212-1-gert@greenie.muc.de>
URL: https://sourceforge.net/p/openvpn/mailman/message/59237450/
Signed-off-by: Gert Doering <gert@greenie.muc.de>
---

diff --git a/configure.ac b/configure.ac
index 38b14a1ea..0fc21ee52 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1388,9 +1388,9 @@ fi
 # required for gcc, but some compilers such as clang need it.
 AC_DEFUN([ACL_CHECK_ADD_COMPILE_FLAGS], [
     old_cflags="$CFLAGS"
-    CFLAGS="$1 -Werror $CFLAGS"
+    CFLAGS="-Werror $CFLAGS $1"
     AC_MSG_CHECKING([whether the compiler accepts $1])
-    AC_COMPILE_IFELSE([AC_LANG_PROGRAM()], [AC_MSG_RESULT([yes])]; CFLAGS="$1 $old_cflags",
+    AC_COMPILE_IFELSE([AC_LANG_PROGRAM()], [AC_MSG_RESULT([yes])]; CFLAGS="$old_cflags $1",
         [AC_MSG_RESULT([no]); CFLAGS="$old_cflags"])]
 )