From: Karel Zak Date: Thu, 14 Oct 2021 08:22:14 +0000 (+0200) Subject: docs: add note about GitHub PR X-Git-Tag: v2.38-rc1~228 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9c2b43b19f3b375fae6daedf2a44b545207ab9e9;p=thirdparty%2Futil-linux.git docs: add note about GitHub PR Signed-off-by: Karel Zak --- diff --git a/Documentation/howto-pull-request.txt b/Documentation/howto-pull-request.txt index c35ae03abc..34ee1ca1ce 100644 --- a/Documentation/howto-pull-request.txt +++ b/Documentation/howto-pull-request.txt @@ -128,7 +128,17 @@ git rebase -i master # change something git push -f yourgit textual:textual -4. Assuming the changes look good send them to mail list. Yes, the all +4. You have two ways how to send your pull request: + +4.1 Github pull request + +This is recommended way for your small and trivial changes, or for +work-in-progress projects (rewrites, new commands, etc.). All you +need is to press "pull request" button on GitHub. + +4.2. Send your work to the mailing list + +Assuming the changes look good send them to mail list. Yes, the all of them! Sending pull request with github is not visible for project contributors, and they will not have change to review your changes.