From: Jiri Denemark <jdenemar@redhat.com>
Date: Wed, 27 Jul 2022 13:40:12 +0000 (+0200)
Subject: qemu: Properly release job in qemuDomainSaveInternal
X-Git-Tag: v8.6.0-rc2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9c3d398df11024ef6c00a50c98fcc0f1f66c16a1;p=thirdparty%2Flibvirt.git

qemu: Properly release job in qemuDomainSaveInternal

The function would fail to release the job in case
qemuMigrationSrcIsAllowed failed.

Fixes v8.5.0-157-g69e0e33873

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 9013e6fb8d..019ec4a035 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -2656,7 +2656,7 @@ qemuDomainSaveInternal(virQEMUDriver *driver,
         goto cleanup;
 
     if (!qemuMigrationSrcIsAllowed(driver, vm, false, VIR_ASYNC_JOB_SAVE, 0))
-        goto cleanup;
+        goto endjob;
 
     if (!virDomainObjIsActive(vm)) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",