From: Javier Carrasco Date: Sun, 13 Oct 2024 13:20:24 +0000 (+0200) Subject: platform/chrome: cros_ec_typec: fix missing fwnode reference decrement X-Git-Tag: v6.13-rc1~198^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9c41f371457bd9a24874e3c7934d9745e87fbc58;p=thirdparty%2Fkernel%2Flinux.git platform/chrome: cros_ec_typec: fix missing fwnode reference decrement The device_for_each_child_node() macro requires explicit calls to fwnode_handle_put() upon early exits (return, break, goto) to decrement the fwnode's refcount, and avoid levaing a node reference behind. Add the missing fwnode_handle_put() after the common label for all error paths. Cc: stable@vger.kernel.org Fixes: fdc6b21e2444 ("platform/chrome: Add Type C connector class driver") Signed-off-by: Javier Carrasco Link: https://lore.kernel.org/r/20241013-cross_ec_typec_fwnode_handle_put-v2-1-9182b2cd7767@gmail.com Signed-off-by: Tzung-Bi Shih --- diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index c7781aea0b88b..f1324466efac6 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -409,6 +409,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec) return 0; unregister_ports: + fwnode_handle_put(fwnode); cros_unregister_ports(typec); return ret; }