From: Christoph Hellwig Date: Thu, 13 Nov 2025 08:39:49 +0000 (+0100) Subject: mempool: legitimize the io_schedule_timeout in mempool_alloc_from_pool X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9c4391767f31d4114da577ab87437f28c1171d6d;p=thirdparty%2Flinux.git mempool: legitimize the io_schedule_timeout in mempool_alloc_from_pool The timeout here is and old workaround with a Fixme comment. But thinking about it, it makes sense to keep it, so reword the comment. Signed-off-by: Christoph Hellwig Link: https://patch.msgid.link/20251113084022.1255121-9-hch@lst.de Signed-off-by: Vlastimil Babka --- diff --git a/mm/mempool.c b/mm/mempool.c index b45bcf4151478..9ec3a04a0130e 100644 --- a/mm/mempool.c +++ b/mm/mempool.c @@ -427,10 +427,10 @@ fail: spin_unlock_irqrestore(&pool->lock, flags); /* - * Wait for someone else to return an element to @pool. - * - * FIXME: this should be io_schedule(). The timeout is there as - * a workaround for some DM problems in 2.6.18. + * Wait for someone else to return an element to @pool, but wake + * up occasionally as memory pressure might have reduced even + * and the normal allocation in alloc_fn could succeed even if + * no element was returned. */ io_schedule_timeout(5 * HZ); finish_wait(&pool->wait, &wait);