From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Fri, 21 Jan 2022 13:54:58 +0000 (+0100)
Subject: MINOR: quic: do not use quic_conn after dropping it
X-Git-Tag: v2.6-dev1~104
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=9c4da93796f14db372809e5e4ab7d76c9f190327;p=thirdparty%2Fhaproxy.git

MINOR: quic: do not use quic_conn after dropping it

quic_conn_drop decrement the refcount and may free the quic_conn if
reaching 0. The quic_conn should not be dereferenced again after it in
any case even for traces.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index 469910edd4..601e997b40 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -3426,8 +3426,9 @@ void quic_close(struct connection *conn, void *xprt_ctx)
 		conn_ctx->wait_event.tasklet = NULL;
 	}
 
-	quic_conn_drop(qc);
 	TRACE_LEAVE(QUIC_EV_CONN_CLOSE, qc);
+
+	quic_conn_drop(qc);
 }
 
 /* Callback called upon loss detection and PTO timer expirations. */